Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: add note about timer unref #34143

Closed
wants to merge 1 commit into from
Closed

http: add note about timer unref #34143

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jun 30, 2020

This tripped me a bit and was not trivial to git blame. Adding a comment.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jun 30, 2020
@ronag
Copy link
Member Author

ronag commented Jun 30, 2020

@nodejs/http

@ronag ronag requested review from bnoordhuis, jasnell and addaleax July 5, 2020 17:09
@ronag
Copy link
Member Author

ronag commented Jul 8, 2020

@nodejs/http

jasnell
jasnell approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this is likely something we should revisit at some point.

@ronag
Copy link
Member Author

ronag commented Jul 9, 2020

Landed in e8f5745

@ronag ronag closed this Jul 9, 2020
ronag added a commit that referenced this pull request Jul 9, 2020
@ronag
http: add note about timer unref
e8f5745 
PR-URL: #34143
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@ronag @MylesBorins
http: add note about timer unref
a30f5b3 
PR-URL: #34143
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@ronag @MylesBorins
http: add note about timer unref
96ebd5f 
PR-URL: #34143
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@ronag @addaleax
http: add note about timer unref
6415185 
PR-URL: #34143
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@ronag @addaleax
http: add note about timer unref
4e07faa 
PR-URL: #34143
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronag @jasnell @trivikr @nodejs-github-bot