Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix unused namespace member #34212

Closed
wants to merge 1 commit into from
Closed

src: fix unused namespace member #34212

wants to merge 1 commit into from

Conversation

branisha
Copy link
Contributor

@branisha branisha commented Jul 5, 2020

make -j4 test fails because of C++ linter saying:

Running C++ linter...
File "src/env.cc" does not use "ArrayBuffer"
make[2]: *** [Makefile:1337: tools/.cpplintstamp] Error 1
make[1]: *** [Makefile:1376: lint] Error 2
make: *** [Makefile:320: test] Error 2

Reverting commit ee3243f removes problem.

After removing using v8::ArrayBuffer; build passes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@branisha
src: fix unused namespace member
c8e5760 
C++ linter fails because of unused ArrayBuffer namespace member
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 5, 2020
addaleax
addaleax approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this!

@addaleax
Copy link
Member

addaleax commented Jul 5, 2020

Collaborators, please 👍 this comment to approve fast-tracking

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jul 5, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32224/

gireeshpunathil pushed a commit that referenced this pull request Jul 6, 2020
@branisha @gireeshpunathil
src: fix unused namespace member
82c435d 
C++ linter fails because of unused ArrayBuffer namespace member

PR-URL: #34212
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

landed in 82c435d , thanks for the contribution!

MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@branisha @MylesBorins
src: fix unused namespace member
7915214 
C++ linter fails because of unused ArrayBuffer namespace member

PR-URL: #34212
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@branisha @MylesBorins
src: fix unused namespace member
8f7ed40 
C++ linter fails because of unused ArrayBuffer namespace member

PR-URL: #34212
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@branisha @addaleax
src: fix unused namespace member
0083543 
C++ linter fails because of unused ArrayBuffer namespace member

PR-URL: #34212
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@branisha @addaleax @nodejs-github-bot @gireeshpunathil @jasnell @gengjiawen @richardlau