Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x] fs: Backport eadc385, fix for fsPromises.truncate #34239

Closed
wants to merge 1 commit into from
Closed

[12.x] fs: Backport eadc385, fix for fsPromises.truncate #34239

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 7, 2020

Fixes: #34189

fsPromises.truncate() was not closing the opened FileHandle.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@joaocgreis @jasnell
fs: close file descriptor of promisified truncate
2073a78 
PR-URL: nodejs#28858
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. v12.x labels Jul 7, 2020
@jasnell jasnell requested a review from richardlau July 7, 2020 14:04
@richardlau
Copy link
Member

Will this also need to be backported to 10.x?

@jasnell
Copy link
Member Author

jasnell commented Jul 7, 2020

Will this also need to be backported to 10.x?

Possibly, Likely.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32237/

jasnell pushed a commit that referenced this pull request Jul 9, 2020
@joaocgreis @jasnell
fs: close file descriptor of promisified truncate
04fa6d6 
Original PR:
  PR-URL: #28858
  Reviewed-By: Rich Trott <rtrott@gmail.com>
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #34239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@jasnell
Copy link
Member Author

jasnell commented Jul 9, 2020

Landed in 04fa6d6

@jasnell jasnell closed this Jul 9, 2020
@pittst3r pittst3r mentioned this pull request Jul 13, 2020
Merged
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@joaocgreis @codebytere
fs: close file descriptor of promisified truncate
7aac983 
Original PR:
  PR-URL: #28858
  Reviewed-By: Rich Trott <rtrott@gmail.com>
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #34239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @richardlau @nodejs-github-bot @addaleax @Flarna @joaocgreis