Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,doc,test: remove String::New default parameter #34248

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jul 7, 2020

kNormal has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81
@addaleax addaleax requested a review from a team July 7, 2020 20:08
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 7, 2020
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 9, 2020
@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member

jasnell commented Jul 9, 2020

@addaleax ... To make this easier to backport, I would separate out the changes to any of the quic files into a separate commit.

@addaleax
Copy link
Member Author

addaleax commented Jul 9, 2020

@jasnell I’m expecting to have to backport this manually everywhere anyway ;)

addaleax added a commit that referenced this pull request Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

PR-URL: #34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member Author

Landed in a038199

@addaleax addaleax closed this Jul 14, 2020
@addaleax addaleax deleted the no-kNormal branch July 14, 2020 13:13
addaleax added a commit to addaleax/node that referenced this pull request Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

PR-URL: nodejs#34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

PR-URL: nodejs#34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

Backport-PR-URL: #34358
PR-URL: #34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

Backport-PR-URL: #34358
PR-URL: #34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: v8/v8@e0d7f81

PR-URL: #34248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants