Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add regression tests for HTTP parser crash #34250

Closed
wants to merge 2 commits into from
Closed

test: add regression tests for HTTP parser crash #34250

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jul 7, 2020 •
edited
Loading

Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102
Refs: #34016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: add regression tests for HTTP parser crash
59408fb 
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: nodejs#15102
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 7, 2020
@addaleax addaleax added http Issues or PRs related to the http subsystem. dont-land-on-v12.x labels Jul 7, 2020
@addaleax addaleax mentioned this pull request Jul 7, 2020
Closed
3 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32239/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 7, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32245/ (:green_heart:)

@github-actions github-actions bot mentioned this pull request Jul 8, 2020
Open
18 tasks
@bnoordhuis
Copy link
Member

Refs: #15102

Also #34016, (almost) the same issue.

This was referenced Jul 9, 2020
Open
Open
Open
Open
Open
Open
@addaleax
Copy link
Member Author

Landed in 18667ac

addaleax added a commit that referenced this pull request Jul 14, 2020
@addaleax
test: add regression tests for HTTP parser crash
18667ac 
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax closed this Jul 14, 2020
@addaleax addaleax deleted the test-http-sync-error branch July 14, 2020 13:03
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@addaleax @MylesBorins
test: add regression tests for HTTP parser crash
a70a5a5 
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@addaleax @MylesBorins
test: add regression tests for HTTP parser crash
3ee8f53 
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@addaleax @cjihrig
test: add regression tests for HTTP parser crash
24df1c0 
Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: #15102

PR-URL: #34250
Refs: #34016
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @bnoordhuis @lpinca