Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/api: module syncBuiltinESMExports example fix #34284

Merged
merged 1 commit into from
Jan 10, 2021
Merged

doc/api: module syncBuiltinESMExports example fix #34284

merged 1 commit into from
Jan 10, 2021

Conversation

bmacnaughton
Copy link
Contributor

Fix failing code and add explanations of each assert.

Checklist

Fix incorrect assert expectations, add explanation of what each assert is verifying.
Define assert so the example is self-contained.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Jul 10, 2020
guybedford
guybedford approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmacnaughton for fixing this up!

@bmacnaughton
Copy link
Contributor Author

Is there something I need to do in order to fix the failing checks? I see no errors in the output (and the example code in docs doesn't get executed afaict).

Also, if there is any feedback for me regarding how I can improve PRs let me know. I'm a novice.

@guybedford
Copy link
Contributor

The failure just seems to be some flakey tests on the GitHub CI process. No need to fix anything.

@aduh95
Copy link
Contributor

aduh95 commented Nov 8, 2020

@bmacnaughton can you rebase to resolve the conflicts please?

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label Nov 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2020

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2021

Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

@github-actions github-actions bot closed this Jan 9, 2021
@guybedford guybedford reopened this Jan 9, 2021
@guybedford
Copy link
Contributor

Reopening as this is a valid docs bug we should fix.

@guybedford
Copy link
Contributor

The diff here is exactly the same but against the module.md file insted of the modules.md file.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 9, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 10, 2021
@bmacnaughton @aduh95
doc: fix module syncBuiltinESMExports example
28e9c10 
Fix failing code and add explanations of each assert.

PR-URL: nodejs#34284
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Jan 10, 2021

Landed in 28e9c10

@aduh95 aduh95 merged commit 28e9c10 into nodejs:master Jan 10, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@bmacnaughton @danielleadams
doc: fix module syncBuiltinESMExports example
153be6c 
Fix failing code and add explanations of each assert.

PR-URL: #34284
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@bmacnaughton @targos
doc: fix module syncBuiltinESMExports example
5770ae0 
Fix failing code and add explanations of each assert.

PR-URL: #34284
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. stalled Issues and PRs that are stalled.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmacnaughton @guybedford @aduh95 @nodejs-github-bot