Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "http2: streamline OnStreamRead streamline memory accounting" #34315

Closed
wants to merge 0 commits into from
Closed

Revert "http2: streamline OnStreamRead streamline memory accounting" #34315

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 11, 2020

This reverts commit 51ccf1b.

Fixes: #31089

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. labels Jul 11, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 11, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32291/ ✔️

addaleax
addaleax approved these changes Jul 11, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @lundibundi

@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

CI passed on the first try, so that's encouraging. I'm going to set up two CI jobs to confirm that this change fixes the flaky test.

@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

CI stress test with this change (should pass): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37209/

CI stress test on master branch without this change (should fail a lot): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37210/

@Trott
Copy link
Member Author

Trott commented Jul 12, 2020

CI stress test with this change (should pass): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37209/

CI stress test on master branch without this change (should fail a lot): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37210/

Results are as expected.

cc other approvers of original PR: @devnexen @jasnell

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2020
lundibundi
lundibundi approved these changes Jul 12, 2020
View reviewed changes
src/node_http2.cc Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Jul 14, 2020

Landed in e1b336f

Trott added a commit that referenced this pull request Jul 14, 2020
@Trott
Revert "http2: streamline OnStreamRead streamline memory accounting"
e1b336f 
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@Trott Trott closed this Jul 14, 2020
@Trott Trott deleted the fix-31089 branch July 14, 2020 14:29
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@Trott @MylesBorins
Revert "http2: streamline OnStreamRead streamline memory accounting"
dcf22b6 
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@Trott @MylesBorins
Revert "http2: streamline OnStreamRead streamline memory accounting"
16160e6 
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
lundibundi added a commit to lundibundi/node that referenced this pull request Jul 22, 2020
@lundibundi
http2: avoid unnecessary buffer resize
a343d35 
Refs: nodejs#34315
Refs: nodejs#30351
@lundibundi lundibundi mentioned this pull request Jul 22, 2020
Closed
4 tasks
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@Trott @cjihrig
Revert "http2: streamline OnStreamRead streamline memory accounting"
1343932 
This reverts commit 51ccf1b.

Fixes: #31089

PR-URL: #34315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
mcollina pushed a commit that referenced this pull request Jul 27, 2020
@lundibundi @mcollina
http2: avoid unnecessary buffer resize
62198d2 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@lundibundi @MylesBorins
http2: avoid unnecessary buffer resize
098b193 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
clshortfuse pushed a commit to clshortfuse/node that referenced this pull request Oct 7, 2020
@Trott @clshortfuse
Revert "http2: streamline OnStreamRead streamline memory accounting"
6802870 
This reverts commit 51ccf1b.

Fixes: nodejs#31089

PR-URL: nodejs#34315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 13, 2020
@Trott @MylesBorins
Revert "http2: streamline OnStreamRead streamline memory accounting"
b5bc280 
This reverts commit 51ccf1b.

Fixes: #31089

Backport-PR-URL: #34845
PR-URL: #34315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
codebytere pushed a commit that referenced this pull request Nov 3, 2020
@lundibundi @codebytere
http2: avoid unnecessary buffer resize
8d8d2b4 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@Trott @MylesBorins
Revert "http2: streamline OnStreamRead streamline memory accounting"
bfce0eb 
This reverts commit 51ccf1b.

Fixes: #31089

Backport-PR-URL: #34845
PR-URL: #34315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@lundibundi @MylesBorins
http2: avoid unnecessary buffer resize
c8a7789 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@devnexen devnexen devnexen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky test-http2-large-writes-session-memory-leak on Windows CI
7 participants
@Trott @nodejs-github-bot @jasnell @addaleax @devnexen @lundibundi @codebytere