repl: give repl entries unique names. fixes #33233 #34372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeck
added
confirmed-bug
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: nodejs#1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284
devsnek
reviewed
Jul 15, 2020
bmeck
commented
Jul 15, 2020
BridgeAR
approved these changes
Jul 21, 2020
antsmartian
approved these changes
Jul 29, 2020
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
bmeck
added
the
author ready
This was referenced Jul 29, 2020
This was referenced Aug 3, 2020
|
CI error is unrelated, known, and being worked on separately; will be landing this later today |
bmeck
added a commit
that referenced
this pull request
Aug 3, 2020
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: #1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: #34372 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
Landed in ca26eae |
This was referenced Aug 4, 2020
codebytere
pushed a commit
that referenced
this pull request
Aug 6, 2020
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: #1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: #34372 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Aug 11, 2020
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: #1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: #34372 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 3, 2020
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: #1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: #34372 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: #1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: #34372 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a workaround for the REPL for https://bugs.chromium.org/p/v8/issues/detail?id=10284
this does not fix vm.* as that requires upstream fixes
this does make the inspector UI have less confusing naming (no synthetic VM*** names for repl entries), but is not the main reason for the PR.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes