Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add writable and readable options to Duplex docs #34383

Closed
wants to merge 1 commit into from
Closed

doc: add writable and readable options to Duplex docs #34383

wants to merge 1 commit into from

Conversation

preyunk
Copy link
Contributor

@preyunk preyunk commented Jul 15, 2020 •
edited
Loading

Fixes: #34382

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 15, 2020
@preyunk
Copy link
Contributor Author

preyunk commented Jul 15, 2020

ping @ronag

ronag
ronag approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 9, 2020 •
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32693/ ✅

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2020
rickyes pushed a commit that referenced this pull request Aug 10, 2020
@preyunk @rickyes
doc: add writable and readable options to Duplex docs
3ddf2c9 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@rickyes
Copy link
Contributor

rickyes commented Aug 10, 2020

Landed in 3ddf2c9

@preyunk congratulations on your first commit to Node.js! 🎉

@rickyes rickyes closed this Aug 10, 2020
@preyunk
Copy link
Contributor Author

preyunk commented Aug 10, 2020

@rickyes Thanks, looking forward to contribute more.

MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@preyunk @MylesBorins
doc: add writable and readable options to Duplex docs
4377690 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@preyunk @BethGriggs
doc: add writable and readable options to Duplex docs
b93ba07 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@preyunk @addaleax
doc: add writable and readable options to Duplex docs
2260037 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@preyunk @addaleax
doc: add writable and readable options to Duplex docs
0ba9052 
Fixes: #34382

PR-URL: #34383
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyes rickyes rickyes approved these changes

@juanarbol juanarbol juanarbol approved these changes

@ronag ronag ronag approved these changes

@willin willin willin approved these changes

@antsmartian antsmartian antsmartian approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add 'writable' and 'readable' to 'new stream.Duplex(options)' docs.
9 participants
@preyunk @nodejs-github-bot @rickyes @jasnell @addaleax @antsmartian @willin @ronag @juanarbol