doc: strengthen suggestion in errors.md #34390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
At least I'm not dogmatic, I guess? |
addaleax
approved these changes
Jul 16, 2020
targos
approved these changes
Jul 16, 2020
Trott
added
the
author ready
juanarbol
approved these changes
Jul 17, 2020
jasnell
approved these changes
Jul 17, 2020
tniessen
approved these changes
Jul 17, 2020
lpinca
approved these changes
Jul 18, 2020
|
Landed in 0c81cad |
Trott
added a commit
that referenced
this pull request
Jul 18, 2020
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: #34390 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: #34390 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: #34390 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: #34390 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: #34390 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sure, I'm advocating for permitting second-person pronouns in a current
PR, but the use in errors.md is superfluous and weakens the sentence.
Remove it.
Checklist