build: add iojs installer assets for win & osx #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added visual assets used by WiX on Windows and PackageMaker on OS X to build the native installers. Added node.ico file with the new io.js logo for Windows.
|
I also have updates for tools/osx-pkg.pmdoc but that's more complicated since I'm now templating index.xml to insert version details (should do the same for the Windows installer too), so I'll leave that as a TODO for me |
piscisaureus
added a commit
that referenced
this pull request
Jan 14, 2015
Added visual assets used by WiX on Windows and PackageMaker on OS X to build the native installers. Added node.ico file with the new io.js logo for Windows. PR: #344 Reviewed-by: Bert Belder <bertbelder@gmail.com>
|
lgtm. Landed (without the new icon) in 8f7538e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added visual assets used by WiX on Windows and PackageMaker on OS X to build the native installers.
Added node.ico file with the new io.js logo for Windows.
Review someone please. @piscisaureus?