Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixup worker + source map test #34446

Closed
wants to merge 1 commit into from

Commits on Jul 20, 2020

  1. test: fixup worker + source map test

    The messaging code uses `Object.defineProperty()`, which accesses
    `value` on `Object.prototype` by default, so some calls to the
    getter here would actually be expected. Instead, make the list
    of accessed properties more specific to the tested source map
    code to avoid flakiness.
    
    Refs: https://twitter.com/addaleax/status/1276289101671608320
    Refs: nodejs#34057
    addaleax committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    f23670e View commit details
    Browse the repository at this point in the history