test: replace flaky pummel regression tests #34530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Jul 28, 2020
This comment has been minimized.
This comment has been minimized.
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: nodejs#34527
This comment has been minimized.
This comment has been minimized.
|
@nodejs/testing @nodejs/fs This could use another review. |
|
(I rebased to eliminate a trivial merge conflict and then force-pushed. Just in case anyone is wondering what is up with my force-push to Anna's branch.) |
This was referenced Jul 31, 2020
This comment has been minimized.
This comment has been minimized.
Trott
reviewed
Jul 31, 2020
Co-authored-by: Rich Trott <rtrott@gmail.com>
This was referenced Aug 1, 2020
This comment has been minimized.
This comment has been minimized.
Trott
added
the
flaky-test
This was referenced Aug 2, 2020
|
@nodejs/collaborators This could use another review. |
This was referenced Aug 3, 2020
puzpuzpuz
approved these changes
Aug 3, 2020
This was referenced Aug 4, 2020
gengjiawen
approved these changes
Aug 4, 2020
|
Landed in 0bb70b0 |
gengjiawen
pushed a commit
that referenced
this pull request
Aug 4, 2020
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: #34527 PR-URL: #34530 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
gengjiawen
reviewed
Aug 4, 2020
This was referenced Aug 5, 2020
This was referenced Aug 6, 2020
codebytere
pushed a commit
that referenced
this pull request
Aug 6, 2020
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: #34527 PR-URL: #34530 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This was referenced Aug 7, 2020
Merged
codebytere
pushed a commit
that referenced
this pull request
Aug 11, 2020
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: #34527 PR-URL: #34530 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were written a long time ago, and use the allocation of
large amounts of unused memory as a way to detect use-after-free
problems with Buffers. As a result, the tests are resource-intensive
and may crash because of that.
Replace them with a more modern test. We don’t explicitly try to
detect use-after-free conditions, and instead rely on e.g. ASAN
(or the process just crashing hard) to do that for us.
Fixes: #34527
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes