Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.7.0 proposal #34542

Merged
merged 75 commits into from
Jul 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
8ca8042
test: fix flaky test-net-connect-econnrefused
Trott Jul 13, 2020
f60e58b
doc,tools: syntax highlight api docs at compile-time
tolmasky Jun 30, 2020
c9b652f
vm: add tests for function declarations using [[DefineOwnProperty]]
ExE-Boss Jun 23, 2020
c28453a
doc: fix typo in assert.md
pastelmind Jul 12, 2020
3d4f608
stream: rename opts to options
rickyes Jul 13, 2020
346c201
doc: strengthen wording about fs.access() misuse
Trott Jul 14, 2020
ec1393d
test: fix test-net-pingpong pummel test for non-IPv6 hosts
Trott Jul 14, 2020
668632d
net: allow wider regex in interface name
Jul 14, 2020
699da05
test: remove common.localhostIPv6
Trott Jul 14, 2020
77542a4
test: do not write to fixtures dir in test-watch-file
Trott Jul 15, 2020
50fd2b9
doc: strengthen suggestion in errors.md
Trott Jul 16, 2020
10962c8
doc: introduce a triager role
gireeshpunathil Jul 10, 2020
1083073
doc: add changes metadata to TLS newSession event
tniessen Jul 10, 2020
aef41e5
src: refactor CertCbDone to avoid goto statement
tniessen Jul 12, 2020
e9c7722
tls: remove setMaxSendFragment guards
tniessen Jul 12, 2020
9d40af5
src: avoid strcmp in SecureContext::Init
tniessen Jul 12, 2020
4a828c6
doc: use correct identifier for callback argument
Trott Jul 17, 2020
30da332
test: fix flaky test-heapdump-http2
Trott Jul 17, 2020
39894f8
doc: add release key for Richard Lau
richardlau Jul 16, 2020
74da2c4
util: improve getStringWidth performance
BridgeAR May 31, 2020
5c94358
src: allow setting a dir for all diagnostic output
May 27, 2020
82fad58
lib: simplify assignment
sapics Jun 4, 2020
d67a2b8
doc: fix typos in n-api, tls and worker_threads
jucke Jul 18, 2020
905e3d1
doc: fix line length in worker_threads.md
jucke Jul 18, 2020
631dd21
doc: mark Node.js 13 as End-of-Life
aduh95 Jul 20, 2020
29ad6fb
doc: add statement of purpose to documentation style guide
Trott Jul 18, 2020
f4d61c7
tools: update ESLint to 7.5.0
cjihrig Jul 18, 2020
02ae6d6
dgram: add IPv6 scope id suffix to received udp6 dgrams
pekkanikander Jul 26, 2017
4b4eb5f
doc: add rexagod to collaborators
rexagod Jul 21, 2020
bd9ab00
src: allow preventing SetPromiseRejectCallback
codebytere Jul 16, 2020
3fda3d4
build: don't run Actions on non-master pushes
codebytere Jul 21, 2020
d6ee1fd
src: do not crash if ToggleAsyncHook fails during termination
addaleax Jul 14, 2020
eecb92c
test: fix flaky test-watch-file
Trott Jul 18, 2020
252f376
zlib: switch to lazy init for zlib streams
puzpuzpuz Jun 23, 2020
a3c9f75
doc: add HarshithaKP to collaborators
HarshithaKP Jul 18, 2020
7d058a4
doc: add author-ready label ref to onboarding doc
ruyadorno Jul 15, 2020
cd35d00
test: force resigning of app
cjihrig Jul 13, 2020
4e2f5fa
test: fixup worker + source map test
addaleax Jun 25, 2020
1a9138d
test: delete invalid test
addaleax Jun 25, 2020
f4a63f3
doc: add AshCripps to collaborators
Jul 23, 2020
455dd9c
doc: match link text in index to doc headline
Trott Jul 20, 2020
cbe6385
src: remove unused variable in node_file.cc
sapics Jul 11, 2020
e1199af
module: self referential modules in repl or `-r`
dnlup Jul 16, 2020
70f23eb
build: remove test-tarball action for windows + osx
MylesBorins Jul 20, 2020
657f2d7
doc: move ronkorving to emeritus
Trott Jul 22, 2020
92c57b2
doc: move thefourtheye to emeritus
Trott Jul 22, 2020
81eaaa2
test: remove duplicate checks in pummel/test-timers
Trott Jul 22, 2020
bbc7eea
doc: mention triage in GOVERNANCE.md
gireeshpunathil Jul 19, 2020
99a6487
doc: onboarding process extras
gireeshpunathil Jul 21, 2020
3f11ba1
test: fix test-heapdump-zlib
puzpuzpuz Jul 23, 2020
e7c64af
n-api: run all finalizers via SetImmediate()
Jul 15, 2020
2297d74
doc: add Triagers section to table of contents in GOVERNANCE.md
Trott Jul 24, 2020
cc279db
test: remove superfluous check in pummel/test-timers
Trott Jul 23, 2020
9b91467
http: don't write error to socket
ronag Jul 21, 2020
b12211e
src: prefer internal fields in ModuleWrap
addaleax Jul 21, 2020
c05b63d
src: skip weak references for memory tracking
addaleax Jul 21, 2020
050866d
doc: remove breaking-change-helper from onboarding-extras
Trott Jul 23, 2020
37752cd
doc: revise onboarding-extras
Trott Jul 23, 2020
17bca62
doc: use sentence-case for GOVERNANCE.md headers
Trott Jul 24, 2020
cce1f3e
build: don't run test-asan workflow on non-master pushes
richardlau Jul 24, 2020
f7600d5
deps: upgrade npm to 6.14.7
claudiahdz Jul 21, 2020
a4806e2
build: speed up source tarball creation
richardlau Jul 24, 2020
098b193
http2: avoid unnecessary buffer resize
lundibundi Jul 22, 2020
3024927
lib: initialize instance members in class constructors
joyeecheung Jul 14, 2020
c93a898
events: expand NodeEventTarget functionality
addaleax Jun 25, 2020
0aa3809
worker: make MessagePort inherit from EventTarget
addaleax Jun 25, 2020
d90967b
events: re-use the same isTrusted getter
addaleax Jul 21, 2020
e5f3800
Revert "doc: move ronkorving to emeritus"
Trott Jul 24, 2020
dd29889
async_hooks: optimize fast-path promise hook for ALS
puzpuzpuz Jul 25, 2020
d5c8b38
test: add ref comment to test-regress-GH-814
Trott Jul 26, 2020
fced3ce
test: add ref comment to test-regress-GH-814_2
Trott Jul 26, 2020
b24f254
build: add benchmark tests to CI runs
Trott Jul 10, 2020
24e1beb
build: do not run benchmark tests on 'make test'
Trott Jul 20, 2020
358b934
build: fix test-ci-js task in Makefile
Trott Jul 20, 2020
6171265
2020-07-29, Version 14.7.0 (Current)
ruyadorno Jul 28, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
87 changes: 8 additions & 79 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: Build from tarball

on: [push, pull_request]
on:
pull_request:
push:
branches:
- master

env:
FLAKY_TESTS: dontcare
Expand All @@ -9,7 +13,7 @@ jobs:
build-tarball:
env:
PYTHON_VERSION: 3.8
runs-on: macos-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
Expand All @@ -22,8 +26,8 @@ jobs:
run: |
export DISTTYPE=nightly
export DATESTRING=`date "+%Y-%m-%d"`
export COMMIT=xxxx
./configure && make tar -j8
export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
./configure && make tar -j8 SKIP_XZ=1
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
Expand Down Expand Up @@ -64,78 +68,3 @@ jobs:
run: |
cd $TAR_DIR
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
test-tarball-windows:
needs: build-tarball
runs-on: windows-latest
steps:
- name: Set up autocrlf
run: |
git config --global core.autocrlf true
- uses: actions/checkout@v2
- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
python-version: 3.8
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@v1
with:
name: tarballs
- name: Extract tarball
run: |
7z x tarballs/*.tar.gz
7z x *.tar -ttar
- name: Install deps
run: choco install nasm
- name: Build
run: |
$env:DEBUG_HELPER=1
$tarfile = dir *.tar
cd $tarfile.BaseName
$env:msbuild_args="/binaryLogger:node.binlog"
./vcbuild.bat x64 release msi
echo "::set-env name=TAR_DIR::$pwd"
- name: Copy out directory to checkout dir
run: Move-Item -Path "$env:TAR_DIR\out" -Destination "$env:GITHUB_WORKSPACE"
- name: "Test JS Suites"
shell: cmd
run: |
set DEBUG_HELPER=1
./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-js
- name: "Test C++ Suites"
shell: cmd
run: |
set DEBUG_HELPER=1
./vcbuild.bat release noprojgen nobuild ignore-flaky test-ci-native
test-tarball-macOS:
needs: build-tarball
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v1
with:
PYTHON_VERSION: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@v1
with:
name: tarballs
- name: Extract tarball
run: |
tar xzf tarballs/*.tar.gz
echo "::set-env name=TAR_DIR::`basename tarballs/*.tar.gz .tar.gz`"
- name: Copy directories needed for testing
run: |
cp -r tools/node_modules $TAR_DIR/tools
cp -r tools/eslint-rules $TAR_DIR/tools
- name: Build
run: |
cd $TAR_DIR
make build-ci -j8 V=1
- name: Test
run: |
cd $TAR_DIR
make run-ci -j8 V=1 TEST_CI_ARGS="-p dots"
6 changes: 5 additions & 1 deletion .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: build-windows

on: [push, pull_request]
on:
pull_request:
push:
branches:
- master

env:
PYTHON_VERSION: 3.8
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: linters

on: [push, pull_request]
on:
pull_request:
push:
branches:
- master

env:
PYTHON_VERSION: 3.8
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/misc.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: misc

on: [push, pull_request]
on:
pull_request:
push:
branches:
- master

env:
NODE_VERSION: 12.x
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-asan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: test-asan

on:
push:
branches:
- master
paths-ignore:
- 'doc/**'
pull_request:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: test-linux

on: [push, pull_request]
on:
pull_request:
push:
branches:
- master

env:
PYTHON_VERSION: 3.8
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/test-macos.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
name: test-macOS

on: [push, pull_request]
on:
pull_request:
push:
branches:
- master

env:
PYTHON_VERSION: 3.8
Expand Down
20 changes: 2 additions & 18 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.6.0">14.6.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V14.md#14.7.0">14.7.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.6.0">14.6.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.5.0">14.5.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.4.0">14.4.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V14.md#14.3.0">14.3.0</a><br/>
Expand All @@ -40,23 +41,6 @@ release.
<a href="doc/changelogs/CHANGELOG_V14.md#14.0.0">14.0.0</a><br/>
</td>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V13.md#13.12.0">13.12.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.11.0">13.11.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.10.1">13.10.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.10.0">13.10.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.9.0">13.9.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.8.0">13.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.7.0">13.7.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.6.0">13.6.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.5.0">13.5.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.4.0">13.4.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.3.0">13.3.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.0.1">13.0.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>
</td>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V12.md#12.16.2">12.16.2</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.16.1">12.16.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V12.md#12.16.0">12.16.0</a><br/>
Expand Down
32 changes: 23 additions & 9 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,30 @@

<!-- TOC -->

* [Triagers](#triagers)
* [Collaborators](#collaborators)
* [Collaborator Activities](#collaborator-activities)
* [Technical Steering Committee](#technical-steering-committee)
* [TSC Meetings](#tsc-meetings)
* [Collaborator Nominations](#collaborator-nominations)
* [Collaborator activities](#collaborator-activities)
* [Technical steering committee](#technical-steering-committee)
* [TSC meetings](#tsc-meetings)
* [Collaborator nominations](#collaborator-nominations)
* [Onboarding](#onboarding)
* [Consensus Seeking Process](#consensus-seeking-process)
* [Consensus seeking process](#consensus-seeking-process)

<!-- /TOC -->

## Triagers

Triagers assess newly-opened issues in the nodejs/node and nodejs/help
repositories. There is no GitHub team for triagers at the moment.

Triagers have:
* ability to label issues
* ability to comment, close, and reopen issues

See:

* [A guide for triagers](./doc/guides/contributing/issues.md#triaging-a-bug-report)

## Collaborators

Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository.
Expand Down Expand Up @@ -41,7 +55,7 @@ See:
* [List of Collaborators](./README.md#current-project-team-members)
* [A guide for Collaborators](./doc/guides/collaborator-guide.md)

### Collaborator Activities
### Collaborator activities

* Helping users and novice contributors
* Contributing code and documentation changes that improve the project
Expand Down Expand Up @@ -70,7 +84,7 @@ The current list of TSC members is in
The [TSC Charter][] governs the operations of the TSC. All changes to the
Charter need approval by the OpenJS Foundation Board of Directors.

### TSC Meetings
### TSC meetings

The TSC meets in a voice conference call. Each year, the TSC elects a chair to
run the meetings. The TSC streams its meetings for public viewing on YouTube or
Expand Down Expand Up @@ -104,7 +118,7 @@ the issue tracker is:
and no TSC opposition.
* If there is an extended impasse, a TSC member may make a motion for a vote.

## Collaborator Nominations
## Collaborator nominations

Existing Collaborators can nominate someone to become a Collaborator. Nominees
should have significant and valuable contributions across the Node.js
Expand Down Expand Up @@ -151,7 +165,7 @@ After the nomination passes, a TSC member onboards the new Collaborator. See
[the onboarding guide](./onboarding.md) for details of the onboarding
process.

## Consensus Seeking Process
## Consensus seeking process

The TSC follows a [Consensus Seeking][] decision-making model per the
[TSC Charter][].
Expand Down
20 changes: 11 additions & 9 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ v8:
jstest: build-addons build-js-native-api-tests build-node-api-tests ## Runs addon tests and JS tests
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
--skip-tests=$(CI_SKIP_TESTS) \
$(CI_JS_SUITES) \
$(CI_NATIVE_SUITES)
$(JS_SUITES) \
$(NATIVE_SUITES)

.PHONY: tooltest
tooltest:
Expand Down Expand Up @@ -492,9 +492,11 @@ test-all-valgrind: test-build
test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*

JS_SUITES ?= default
NATIVE_SUITES ?= addons js-native-api node-api
# CI_* variables should be kept synchronized with the ones in vcbuild.bat
CI_NATIVE_SUITES ?= addons js-native-api node-api
CI_JS_SUITES ?= default
CI_NATIVE_SUITES ?= $(NATIVE_SUITES) benchmark
CI_JS_SUITES ?= $(JS_SUITES)
ifeq ($(node_use_openssl), false)
CI_DOC := doctool
else
Expand All @@ -505,7 +507,7 @@ endif
# Build and test addons without building anything else
# Related CI job: node-test-commit-arm-fanned
test-ci-native: LOGLEVEL := info
test-ci-native: | test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
test-ci-native: | benchmark/napi/.buildstamp test/addons/.buildstamp test/js-native-api/.buildstamp test/node-api/.buildstamp
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
$(TEST_CI_ARGS) $(CI_NATIVE_SUITES)
Expand All @@ -527,7 +529,7 @@ test-ci-js: | clear-stalled
.PHONY: test-ci
# Related CI jobs: most CI tests, excluding node-test-commit-arm-fanned
test-ci: LOGLEVEL := info
test-ci: | clear-stalled build-addons build-js-native-api-tests build-node-api-tests doc-only
test-ci: | clear-stalled bench-addons-build build-addons build-js-native-api-tests build-node-api-tests doc-only
out/Release/cctest --gtest_output=xml:out/junit/cctest.xml
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
--mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \
Expand Down Expand Up @@ -654,8 +656,8 @@ test-with-async-hooks:
$(MAKE) build-node-api-tests
$(MAKE) cctest
NODE_TEST_WITH_ASYNC_HOOKS=1 $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) \
$(CI_JS_SUITES) \
$(CI_NATIVE_SUITES)
$(JS_SUITES) \
$(NATIVE_SUITES)


.PHONY: test-v8
Expand Down Expand Up @@ -1034,7 +1036,7 @@ pkg-upload: pkg
scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"

$(TARBALL): release-only $(NODE_EXE) doc
$(TARBALL): release-only doc-only
git checkout-index -a -f --prefix=$(TARNAME)/
mkdir -p $(TARNAME)/doc/api
cp doc/node.1 $(TARNAME)/doc/node.1
Expand Down
Loading