Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use block-scoping in test/pummel/test-timers.js #34630

Merged
merged 0 commits into from
Aug 11, 2020
Merged

test: use block-scoping in test/pummel/test-timers.js #34630

merged 0 commits into from
Aug 11, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 5, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 5, 2020
@Trott
Copy link
Member Author

Trott commented Aug 5, 2020 •
edited by addaleax
Loading

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15751/ (:green_heart:)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 5, 2020
@addaleax addaleax added the review wanted PRs that need reviews. label Aug 8, 2020
@Trott
Copy link
Member Author

Trott commented Aug 11, 2020

Landed in 49a1f7f

@Trott Trott closed this Aug 11, 2020
@Trott Trott force-pushed the block-scope-test-timers branch from bde6b0d to 49a1f7f Compare August 11, 2020 13:16
@Trott Trott merged commit 49a1f7f into nodejs:master Aug 11, 2020
@Trott Trott deleted the block-scope-test-timers branch August 11, 2020 13:16
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@Trott @MylesBorins
test: use block-scoping in test/pummel/test-timers.js
2eaaaf4 
PR-URL: #34630
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
test: use block-scoping in test/pummel/test-timers.js
9f0917e 
PR-URL: #34630
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: use block-scoping in test/pummel/test-timers.js
ba9dd3b 
PR-URL: #34630
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: use block-scoping in test/pummel/test-timers.js
aa24b4a 
PR-URL: #34630
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @addaleax @targos @nodejs-github-bot