build: do not run auto-start-ci on forks #34650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node.
nodejs-github-bot
added
the
meta
|
Can we instead check if the secrets are present, and if not skip the run? I'd like this to still work on forks since sometimes we test this kind of thing on nodejs/node-auto-tools. |
|
@mmarchini that's a good point. Lemme see what I can do |
mmarchini
reviewed
Aug 6, 2020
| @@ -13,6 +13,7 @@ on: | |||
|
|
|||
| jobs: | |||
| startCI: | |||
| if: github.repository == 'nodejs/node' | |||
There was a problem hiding this comment.
Suggested change
| if: github.repository == 'nodejs/node' | |
| if: secrets.JENKINS_USER && secrets.JENKINS_TOKEN |
Also not sure if it works. Feel free to try on nodejs/node-auto-test first (I can re-enable Actions there, just give me a ping).
There was a problem hiding this comment.
It might need to be
Suggested change
| if: github.repository == 'nodejs/node' | |
| if: ${{ secrets.JENKINS_USER && secrets.JENKINS_TOKEN }} |
There was a problem hiding this comment.
https://github.saobby.my.eu.orgmunity/t/jobs-job-id-if-does-not-work-with-env-secrets/16928/5 It doesn't sound like it does work...
|
@evanlucas I re-enabled Actions on https://github.com/nodejs/node-auto-test. Let's test there first, since the Action is working here it's better if we're sure the changes will work. |
|
Sounds good. I'll open a PR over there. I think I've found a way to do it |
|
FWIW you should be able to test on a personal fork as well, just push the changes to master there :) |
mmarchini
approved these changes
Aug 6, 2020
|
fast track? |
jasnell
approved these changes
Aug 7, 2020
richardlau
approved these changes
Aug 7, 2020
richardlau
added
the
fast-track
|
Landed in ac5773b |
mmarchini
pushed a commit
that referenced
this pull request
Aug 7, 2020
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 8, 2020
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Aug 11, 2020
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.
/cc @mmarchini I think this should work, although I'm not sure how to test...
Checklist