Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: fix use-after-free with napi_remove_async_cleanup_hook #34662

Closed
wants to merge 3 commits into from
Closed

n-api: fix use-after-free with napi_remove_async_cleanup_hook #34662

wants to merge 3 commits into from

Commits on Aug 7, 2020

  1. src: fix size underflow in CallbackQueue 

    Only decrease the size when actually removing items.
    @addaleax
    addaleax committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    7ff8795 View commit details
    Browse the repository at this point in the history

  2. src: spin shutdown loop while immediates are pending 

    This allows using `SetImmediate()` and friends at any point
during cleanup.
    @addaleax
    addaleax committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    60941d6 View commit details
    Browse the repository at this point in the history

  3. n-api: fix use-after-free with napi_remove_async_cleanup_hook 

    Fixes: nodejs#34657
Refs: nodejs#34572
    @addaleax
    addaleax committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    b94ceaf View commit details
    Browse the repository at this point in the history