Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix broken links in commit-queue.md #34789

Closed
wants to merge 1 commit into from
Closed

doc: fix broken links in commit-queue.md #34789

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Aug 15, 2020

Fixes: #34787

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 15, 2020
targos
targos reviewed Aug 15, 2020
View reviewed changes
doc/guides/commit-queue.md Outdated Show resolved Hide resolved
@DerekNonGeneric DerekNonGeneric added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 15, 2020
@richardlau richardlau mentioned this pull request Aug 17, 2020
Closed
2 tasks
mmarchini pushed a commit that referenced this pull request Aug 17, 2020
@lpinca @mmarchini
doc: fix broken links in commit-queue.md
92167e2 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@mmarchini
Copy link
Contributor

Landed in 92167e2

@mmarchini mmarchini closed this Aug 17, 2020
@lpinca lpinca deleted the gh-34787 branch August 17, 2020 18:48
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@lpinca @MylesBorins
doc: fix broken links in commit-queue.md
3224091 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@lpinca @BethGriggs
doc: fix broken links in commit-queue.md
e54a684 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lpinca @addaleax
doc: fix broken links in commit-queue.md
82811f7 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lpinca @addaleax
doc: fix broken links in commit-queue.md
c7fc16e 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@lundibundi lundibundi lundibundi approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mmarchini mmarchini mmarchini approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: broken links in doc/guides/commit-queue.md
7 participants
@lpinca @mmarchini @targos @BridgeAR @lundibundi @DerekNonGeneric @nodejs-github-bot