Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: usage of modernize-use-equals-default #34807

Closed
wants to merge 1 commit into from
Closed

src: usage of modernize-use-equals-default #34807

wants to merge 1 commit into from

Conversation

yashLadha
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@yashLadha
src: usage of modernize-use-equals-default
f7f1c71 
Update the destructor and constructor calls to use the default member
function. This will bascially enables the compiler to do better
optimization as the functions as explicitly defined as trivial.

Explanation can be obtained at: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Aug 17, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32904/

Trott pushed a commit that referenced this pull request Aug 23, 2020
@yashLadha @Trott
src: usage of modernize-use-equals-default
c3d337d 
Update the destructor and constructor calls to use the default member
function. This will bascially enable the compiler to do better
optimization as the functions as explicitly defined as trivial.

Refs: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html

PR-URL: #34807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 23, 2020

Landed in c3d337d

@Trott Trott closed this Aug 23, 2020
BethGriggs pushed a commit that referenced this pull request Aug 24, 2020
@yashLadha @BethGriggs
src: usage of modernize-use-equals-default
7666d95 
Update the destructor and constructor calls to use the default member
function. This will bascially enable the compiler to do better
optimization as the functions as explicitly defined as trivial.

Refs: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html

PR-URL: #34807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 25, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@yashLadha @addaleax
src: usage of modernize-use-equals-default
7c74702 
Update the destructor and constructor calls to use the default member
function. This will bascially enable the compiler to do better
optimization as the functions as explicitly defined as trivial.

Refs: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html

PR-URL: #34807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@yashLadha @addaleax
src: usage of modernize-use-equals-default
d953fa3 
Update the destructor and constructor calls to use the default member
function. This will bascially enable the compiler to do better
optimization as the functions as explicitly defined as trivial.

Refs: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html

PR-URL: #34807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yashLadha @nodejs-github-bot @Trott @jasnell @addaleax @cjihrig