Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: claim ABI version for Electron v12 #34816

Closed
wants to merge 1 commit into from
Closed

doc: claim ABI version for Electron v12 #34816

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Claiming Electron's ABI number for v12.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 17, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 17, 2020 •
edited by mmarchini
Loading

Review requested:

  • @nodejs/tsc

@codebytere codebytere changed the title New nmv electron doc: claim ABI version for Electron v12 Aug 17, 2020
mcollina
mcollina approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codebytere
Copy link
Member Author

Landed in 7aeff6b

@codebytere codebytere closed this Aug 20, 2020
codebytere added a commit that referenced this pull request Aug 20, 2020
@codebytere
doc: claim ABI version for Electron v12
7aeff6b 
PR-URL: #34816
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere deleted the new-nmv-electron branch August 20, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@mmarchini mmarchini mmarchini approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@codebytere @nodejs-github-bot @mcollina @jasnell @lpinca @targos @cjihrig @mmarchini @richardlau @BethGriggs