-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esm: shorten ERR_UNSUPPORTED_ESM_URL_SCHEME message #34836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these are technically called DOS paths, but having this say Windows paths is probably ((maybe?)) fine since I don't think anyone is running Node under DOS.
This comment has been minimized.
This comment has been minimized.
I think all comments have been addressed. Assuming CI passes on Windows, PTAL. |
CI: https://ci.nodejs.org/job/node-test-pull-request/32874/ (Not sure if the bot is working again.) |
@DerekNonGeneric Can you please either clear your change request or explain it a bit more? Are you asking that we change the text? Or was the change request about the missing single-quotation mark that has been added? |
I think it's technically wrong, but do as you please. |
@Trott, can you dismiss my stale review? |
Well, let's see if we can come up with something that satisfies you and @lundibundi and anyone else invested. Maybe we don't need to mention Windows specifically at all?
It will only display for Windows users, and that's fine (because that's who needs to see it in this situation). Does that work for everyone? |
Thank you, you are the best. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I know it just got modified to include new information, but this shortens the message a bit without (I hope) losing clarity or meaning. PR-URL: nodejs#34836 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Landed in e1edd6b |
I know it just got modified to include new information, but this shortens the message a bit without (I hope) losing clarity or meaning. PR-URL: #34836 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
I know it just got modified to include new information, but this shortens the message a bit without (I hope) losing clarity or meaning. PR-URL: nodejs#34836 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
I know it just got modified to include new information, but this
shortens the message a bit without (I hope) losing clarity or meaning.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes