[v14.x] http2: use and support non-empty DATA frame with END_STREAM flag #34838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
clshortfuse
changed the title
|
Only difference between this and #33875 are two debug lines that had to be removed. v14.x can't debug a stream object without an attached session. |
clshortfuse
force-pushed
the
fixhttp2-v14.x
branch
from
320f82d
to
56f3725
Compare
|
Rebased against 14.x-staging (was behind 640 commits). Also commented out 14.x incompatible lines instead of just outright removing them. |
clshortfuse
force-pushed
the
fixhttp2-v14.x
branch
from
238de94
to
c434944
Compare
BethGriggs
force-pushed
the
v14.x-staging
branch
from
fd6efbe
to
a16f0f4
Compare
Adds support for reading from a stream where the final frame is a non-empty DATA frame with the END_STREAM flag set, instead of hanging waiting for another frame. When writing to a stream, uses a END_STREAM flag on final DATA frame instead of adding an empty DATA frame. BREAKING: http2 client now expects servers to properly support END_STREAM flag Fixes: nodejs#31309 Fixes: nodejs#33891 Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback
MylesBorins
force-pushed
the
fixhttp2-v14.x
branch
from
c434944
to
8fd8f1d
Compare
|
Went ahead and rebased as the change went out of sync with v14.x-staging CI: https://ci.nodejs.org/job/node-test-pull-request/32872/ @danielleadams it would be very good to get this included in next weeks release. Thanks for the hard work. Resume CI for windows failure: https://ci.nodejs.org/job/node-test-pull-request/32873/ |
MylesBorins
changed the title
9 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Aug 21, 2020
Adds support for reading from a stream where the final frame is a non-empty DATA frame with the END_STREAM flag set, instead of hanging waiting for another frame. When writing to a stream, uses a END_STREAM flag on final DATA frame instead of adding an empty DATA frame. BREAKING: http2 client now expects servers to properly support END_STREAM flag Fixes: #31309 Fixes: #33891 Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback PR-URL: #33875 Backport-PR-URL: #34838 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
landed in 9e0d18f |
This was referenced Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading from a stream where the final frame is a
non-empty DATA frame with the END_STREAM flag set, instead of hanging
waiting for another frame. When writing to a stream, uses a
END_STREAM flag on final DATA frame instead of adding an empty
DATA frame.
BREAKING: http2 client now expects servers to properly support
END_STREAM flag
Fixes: #31309
Fixes: #33891
Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes