meta: add gyp as owner of gyp files and tools/gyp

[mmarchini]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

Review requested:

• @nodejs/tsc

[mmarchini]

cc @nodejs/gyp is it ok to add you as owner of gyp files?

[jasnell]

Likely should also include @nodejs/build

[mmarchini]

Not sure, maybe @nodejs/build-files (which I can do on a follow up PR since there are other files like ./configure and Makefile which should be added)? @nodejs/build is so noisy it might not be worth to have as codeowner.

[mmarchini]

lol linter is failing (and I used a linter locally to check those exact lines 😅). Will figure out before landing, but the idea is to have @nodejs/gyp as owner for all gyp file changes in this repo.

[richardlau]

Is

node/.github/CODEOWNERS

Lines 1 to 6 in 6f0b87d

	# Node.js Project Codeowners
	# 1. Codeowners must always be teams, never individuals
	# 2. Each codeowner team should contain at least one TSC member
	# 3. PRs touching any code with a codeowner must be signed off by at least one
	# person on the code owner team.

still accurate? If so there are no TSC members in the gyp team.

[mmarchini]

Nice catch, I didn't realize that. Is that something we still want to enforce? It's probably a leftover from the first codeowners attempt a while back.

[gengjiawen]

cc @nodejs/gyp is it ok to add you as owner of gyp files?

cc @targos looks like you are not in this group.

[ryzokuken]

cc @nodejs/gyp is it ok to add you as owner of gyp files?

Yes! Thank you.

[mcollina]

lgtm

[ryzokuken]

P.S. I added @mmarchini to @nodejs/gyp so now we do have a TSC member on the team, it would be nice to have @targos on there too, if they are willing.

[targos]

Thanks, I added myself to the team :)

[mmarchini]

#34847 (comment)

[Trott]

(Sorry about the accidental close. Wrong window!)

[aduh95]

@mmarchini This needs a rebase.