Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x] http2: support non-empty DATA frame with END_STREAM flag #34857

Closed
wants to merge 2 commits into from

Commits on Aug 20, 2020

  1. http2,doc: minor fixes

    Some small fixes on HTTP/2 and its documentation:
    
     - Add a note that, on server streams, it's not necessary
       to start data flow.
    
     - Set EOF flag if we have marked all data for sending:
       there's no need to wait until the queue is
       actually empty (and send a separate, empty DATA).
    
       (Note that, even with this change, a separate DATA
       frame will always be sent, because the streams
       layer waits until data has been flushed before
       dispatching EOF)
    
    PR-URL: nodejs#28044
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    mildsunrise authored and clshortfuse committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7e85d4a View commit details
    Browse the repository at this point in the history
  2. http2: support non-empty DATA frame with END_STREAM flag

    Adds support for reading from a stream where the final frame is a
    non-empty DATA frame with the END_STREAM flag set, instead of hanging
    waiting for another frame.
    
    Fixes: nodejs#31309
    Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback
    
    PR-URL: nodejs#33875
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    clshortfuse committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    2a3914d View commit details
    Browse the repository at this point in the history