-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: use ErrorPrototypeToString
from primordials
object
#34891
Closed
ExE-Boss
wants to merge
1
commit into
nodejs:master
from
ExE-Boss:lib/internal/errors/use-primordials-error-prototype-tostring
Closed
errors: use ErrorPrototypeToString
from primordials
object
#34891
ExE-Boss
wants to merge
1
commit into
nodejs:master
from
ExE-Boss:lib/internal/errors/use-primordials-error-prototype-tostring
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
label
Aug 23, 2020
devsnek
approved these changes
Aug 23, 2020
targos
approved these changes
Aug 23, 2020
BridgeAR
approved these changes
Aug 23, 2020
jasnell
approved these changes
Aug 24, 2020
lpinca
approved these changes
Aug 24, 2020
cjihrig
approved these changes
Aug 25, 2020
devsnek
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 25, 2020
github-actions
bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Aug 25, 2020
Commit Queue failed- Loading data for nodejs/node/pull/34891 ✔ Done loading data for nodejs/node/pull/34891 ----------------------------------- PR info ------------------------------------ Title errors: Use `ErrorPrototypeToString` from `primordials` object (#34891) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ExE-Boss:lib/internal/errors/use-primordials-error-prototype-tostring -> nodejs:master Labels errors Commits 1 - errors: Use `ErrorPrototypeToString` from `primordials` object Committers 1 - ExE Boss <3889017+ExE-Boss@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/34891 Reviewed-By: Gus Caplan Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34891 Reviewed-By: Gus Caplan Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ Last Full PR CI on 2020-08-23T17:41:17Z: https://ci.nodejs.org/job/node-test-pull-request/32907/ - Querying data of job/node-test-pull-request/32907/ ✔ Build data downloaded ℹ This PR was created on Sun, 23 Aug 2020 15:45:55 GMT ✔ Approvals: 6 ✔ - Gus Caplan (@devsnek): https://github.com/nodejs/node/pull/34891#pullrequestreview-473024249 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-473024251 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-473026575 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-473596914 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/34891#pullrequestreview-473794806 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-474025385 -------------------------------------------------------------------------------- ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 34891 ✔ Downloaded patch to /home/runner/work/node/node/.ncu/34891/patch -------------------------------------------------------------------------------- Applying: errors: Use `ErrorPrototypeToString` from `primordials` object ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- errors: Use `ErrorPrototypeToString` from `primordials` object |
ExE-Boss
changed the title
errors: Use
errors: use Aug 25, 2020
ErrorPrototypeToString
from primordials
objectErrorPrototypeToString
from primordials
object
ExE-Boss
force-pushed
the
lib/internal/errors/use-primordials-error-prototype-tostring
branch
from
August 25, 2020 22:31
c38afbb
to
1df8048
Compare
cjihrig
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the commit queue bot is OK with the commit message.
devsnek
approved these changes
Aug 26, 2020
devsnek
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Aug 26, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 26, 2020
devsnek
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 26, 2020
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 26, 2020
Landed in 565d993 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 26, 2020
PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ExE-Boss
deleted the
lib/internal/errors/use-primordials-error-prototype-tostring
branch
August 26, 2020 14:01
This should probably also be backported. |
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the
prepareStackTrace
no override fallback path doesn’t get broken byError.prototype.toString.call
not beingFunction.prototype.call
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes