Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: provide more guidance about process.version #34909

Merged
merged 1 commit into from
Aug 27, 2020
Merged

doc: provide more guidance about process.version #34909

merged 1 commit into from
Aug 27, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 24, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Aug 24, 2020
@Trott
doc: provide more guidance about process.version
09e23b8 
PR-URL: nodejs#34909
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Trott Trott force-pushed the process-guidance branch from 66e6587 to 09e23b8 Compare August 27, 2020 13:59
@Trott Trott merged commit 09e23b8 into nodejs:master Aug 27, 2020
@Trott
Copy link
Member Author

Trott commented Aug 27, 2020

Landed in 09e23b8

@Trott Trott deleted the process-guidance branch August 27, 2020 14:00
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@Trott @richardlau
doc: provide more guidance about process.version
fbd18be 
PR-URL: #34909
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: provide more guidance about process.version
494594e 
PR-URL: #34909
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: provide more guidance about process.version
1b27f09 
PR-URL: #34909
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @benjamingr @gireeshpunathil @trivikr @nodejs-github-bot