Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous functions are replaced by the arrow functions. #34921

Closed
wants to merge 1 commit into from
Closed

Anonymous functions are replaced by the arrow functions. #34921

wants to merge 1 commit into from

Conversation

PoojaDurgad
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 25, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32982/

@PoojaDurgad
Copy link
Contributor Author

please let me know if there is anything pending on this

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33132/

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33255/

watilde pushed a commit that referenced this pull request Sep 27, 2020
@PoojaDurgad @watilde
test: replace annonymous functions with arrow
7390098 
PR-URL: #34921
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@watilde
Copy link
Member

watilde commented Sep 27, 2020

Landed in 7390098, thank you!

@watilde watilde closed this Sep 27, 2020
MylesBorins pushed a commit that referenced this pull request Sep 29, 2020
@PoojaDurgad @MylesBorins
test: replace annonymous functions with arrow
f2635b3 
PR-URL: #34921
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@PoojaDurgad @MylesBorins
test: replace annonymous functions with arrow
0327563 
PR-URL: #34921
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@PoojaDurgad @MylesBorins
test: replace annonymous functions with arrow
fdc67eb 
PR-URL: #34921
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@PoojaDurgad @joesepi
test: replace annonymous functions with arrow
4169afc 
PR-URL: nodejs#34921
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@watilde watilde watilde approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PoojaDurgad @nodejs-github-bot @watilde @Trott @HarshithaKP @richardlau