Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Aug 28, 2020

Refs: #34929 (comment)

Checklist

@Trott Trott requested review from a team as code owners August 28, 2020 14:55
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 28, 2020
@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2020
Refs: nodejs#34929 (comment)

PR-URL: nodejs#34956
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@Trott Trott merged commit 07e7ad9 into nodejs:master Aug 30, 2020
@Trott
Copy link
Member Author

Trott commented Aug 30, 2020

Landed in 07e7ad9

@Trott Trott deleted the reference-link branch August 30, 2020 15:37
richardlau pushed a commit that referenced this pull request Sep 1, 2020
Refs: #34929 (comment)

PR-URL: #34956
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@richardlau richardlau mentioned this pull request Sep 2, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants