Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: recommend URL() over url.parse() in http2 doc #34978

Merged
merged 1 commit into from
Sep 1, 2020
Merged

doc: recommend URL() over url.parse() in http2 doc #34978

merged 1 commit into from
Sep 1, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 29, 2020

Checklist

@Trott Trott requested review from a team as code owners August 29, 2020 20:32
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 29, 2020
@Trott Trott force-pushed the url-no-parse branch 2 times, most recently from f59cd32 to 811a0f9 Compare September 1, 2020 02:53
@Trott
doc: recommend URL() over url.parse() in http2 doc
492c34f 
PR-URL: nodejs#34978
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott Trott merged commit 492c34f into nodejs:master Sep 1, 2020
@Trott
Copy link
Member Author

Trott commented Sep 1, 2020

Landed in 492c34f

@Trott Trott deleted the url-no-parse branch September 1, 2020 02:57
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@Trott @richardlau
doc: recommend URL() over url.parse() in http2 doc
df76c89 
PR-URL: #34978
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
@Flarna Flarna mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @addaleax @targos