common.mustcall() is added #34996
Closed
common.mustcall() is added #34996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please enter the commit message for your changes. Lines starting
juanarbol
approved these changes
Aug 31, 2020
|
Thank you!,@juanarbol |
tniessen
approved these changes
Sep 5, 2020
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
Sep 5, 2020
|
Landed in 1111111. |
tniessen
pushed a commit
that referenced
this pull request
Sep 5, 2020
PR-URL: #34996 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Sorry @addaleax, you approved this 20 seconds before I pushed the commit :( |
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #34996 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #34996 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34996 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34996 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#34996 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @Trott, in relation with #34920