Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: don't destroy readable before 'end' #35120

Closed
wants to merge 1 commit into from
Closed

stream: don't destroy readable before 'end' #35120

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Sep 9, 2020

Fixes: #35116

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Sep 9, 2020
@ronag ronag marked this pull request as draft September 9, 2020 10:59
@ronag ronag mentioned this pull request Sep 9, 2020
Closed
2 tasks
@richardlau
Copy link
Member

Requested a CITGM run against got for this PR (queued): https://ci.nodejs.org/job/citgm-smoker/2462/

@richardlau

This comment has been minimized.

Sign in to view
@richardlau richardlau mentioned this pull request Sep 9, 2020
Closed
@ronag
Copy link
Member Author

ronag commented Sep 9, 2020

#35122

@ronag ronag closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v14.10.0 changes behavior of existing code (got)
3 participants
@ronag @richardlau @nodejs-github-bot