doc: simplify circular dependencies text in modules.md #35126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
Review requested:
|
zackschuster
suggested changes
Sep 9, 2020
|
Removing "simply" is awesome; leaving the link seems nice. LGTM otherwise. |
Sure! Done! I just didn't want the link text to be only the word here. |
benjamingr
approved these changes
Sep 10, 2020
trivikr
approved these changes
Sep 10, 2020
zackschuster
approved these changes
Sep 11, 2020
PR-URL: nodejs#35126 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 1df50ff |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
PR-URL: #35126 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35126 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35126 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35126 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist