Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update releaser in v12.18.4 changelog #35217

Closed
wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

Checklist

(Just a retrospective update to reflect who promoted/signed the release.)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 15, 2020
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 16, 2020
@targos
Copy link
Member

targos commented Sep 16, 2020

fast-track?

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v12.x labels Sep 16, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2020
@github-actions
Copy link
Contributor

Landed in 524123f

@github-actions github-actions bot closed this Sep 16, 2020
nodejs-github-bot pushed a commit that referenced this pull request Sep 16, 2020
PR-URL: #35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ruyadorno
Copy link
Member

Adding dont-land-on-v14.x label since I noticed this is bringing in tons of unrelated changes to doc/changelogs/CHANGELOG_V12.md.

Changelog files of older release lines don't seem to usually be touched due to us using branch-diff --filter-release on the release workflow.

MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
PR-URL: #35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 16, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35217
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants