Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: fix build on windows #35229

Merged
merged 1 commit into from
Sep 17, 2020
Merged

deps: V8: fix build on windows #35229

merged 1 commit into from
Sep 17, 2020

Conversation

gengjiawen
Copy link
Member

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 16, 2020
@gengjiawen gengjiawen changed the title deps: update V8 to 8.7.0.0 deps: V8: fix build on windows Sep 16, 2020
@gengjiawen gengjiawen requested a review from targos September 16, 2020 13:11
@gengjiawen gengjiawen mentioned this pull request Sep 16, 2020
Closed
@gengjiawen
Copy link
Member Author

cc @nodejs/v8

@gengjiawen
Copy link
Member Author

CI on windows passed 🎉

targos
targos approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's hope they accept the patch upstream 🤞

@gengjiawen gengjiawen merged commit 497020e into nodejs:canary-base Sep 17, 2020
@gengjiawen gengjiawen deleted the windows_fix branch September 17, 2020 00:32
targos pushed a commit that referenced this pull request Sep 18, 2020
@gengjiawen @targos
deps: V8: fix build on windows (#35229)
fb83c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @addaleax @targos @nodejs-github-bot