Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: Enforce alphabetical order in Markdown files #35244

Merged
merged 2 commits into from
Sep 22, 2020
Merged

tools,doc: Enforce alphabetical order in Markdown files #35244

merged 2 commits into from
Sep 22, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 17, 2020 •
edited
Loading

This PR adds a test to check if references at the bottom of MD files in the code base are ordered.

This also includes a commit to upgrade the dependencies in /tools/doc, necessary to perform the test.

Refs: #35230 (comment)

/cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc
  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Sep 17, 2020
@aduh95 aduh95 changed the title Enforce alphabetical order tools,doc: Enforce alphabetical order in Markdown files Sep 18, 2020
Trott
Trott approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

lpinca
lpinca reviewed Sep 19, 2020
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33196/

@aduh95 @Trott
tools,doc: upgrade dependencies
0b8fdb7 
PR-URL: nodejs#35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@aduh95 @Trott
tools,doc: enforce alphabetical order for md refs
7794d36 
PR-URL: nodejs#35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@Trott Trott merged commit 7794d36 into nodejs:master Sep 22, 2020
@Trott
Copy link
Member

Trott commented Sep 22, 2020

Landed in 219e9fe...7794d36

MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
@aduh95 @MylesBorins
tools,doc: upgrade dependencies
9d91842 
PR-URL: #35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
@aduh95 @MylesBorins
tools,doc: enforce alphabetical order for md refs
c5d27e1 
PR-URL: #35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
Merged
@aduh95 aduh95 mentioned this pull request Sep 30, 2020
Closed
Trott pushed a commit to aduh95/node that referenced this pull request Oct 1, 2020
@aduh95 @Trott
doc: sort md references in ASCII order
57f1e32 
Refs: nodejs#35244

PR-URL: nodejs#35191
Fixes: nodejs#35189
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
@aduh95 @danielleadams
doc: sort md references in ASCII order
5a730b5 
Refs: #35244

PR-URL: #35191
Fixes: #35189
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@aduh95 @MylesBorins
tools,doc: upgrade dependencies
daa9453 
PR-URL: #35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@aduh95 @MylesBorins
tools,doc: enforce alphabetical order for md refs
6cce46b 
PR-URL: #35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
@aduh95 aduh95 deleted the enforce-alphabetical-order branch November 4, 2020 14:04
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@aduh95 @MylesBorins
tools,doc: upgrade dependencies
11b10d7 
PR-URL: #35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@aduh95 @MylesBorins
tools,doc: enforce alphabetical order for md refs
f297174 
PR-URL: #35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
tools,doc: upgrade dependencies
b059e0a 
PR-URL: nodejs#35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
tools,doc: enforce alphabetical order for md refs
b3038a7 
PR-URL: nodejs#35244
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
doc: sort md references in ASCII order
639eb24 
Refs: nodejs#35244

PR-URL: nodejs#35191
Fixes: nodejs#35189
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca left review comments

@codebytere codebytere codebytere approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @Trott @lpinca @codebytere