Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update message to match actual output #35271

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 19, 2020

Checklist

@nodejs-github-bot nodejs-github-bot added debugger doc Issues and PRs related to the documentations. labels Sep 19, 2020
@Trott Trott marked this pull request as draft September 19, 2020 16:23
@Trott Trott marked this pull request as ready for review September 19, 2020 16:23
@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Sep 19, 2020
@Trott
Copy link
Member Author

Trott commented Sep 19, 2020

This is blocked until nodejs/node-inspect#89 lands and makes it into our deps.

@lpinca
Copy link
Member

lpinca commented Oct 5, 2020

@Trott nodejs/node-inspect#89 landed. Can the blocked label be removed?

@Trott
Copy link
Member Author

Trott commented Oct 5, 2020

@Trott nodejs/node-inspect#89 landed. Can the blocked label be removed?

Not until there's a node-inspect release and we incorporate that release into deps/node-inspect.

@targos targos added inspector Issues and PRs related to the V8 inspector protocol and removed debugger labels Dec 27, 2020
@Trott Trott removed the blocked PRs that are blocked by other issues or PRs. label Apr 27, 2021
@Trott
Copy link
Member Author

Trott commented Apr 27, 2021

Required change just landed a few minutes ago.

Trott added a commit to Trott/io.js that referenced this pull request Apr 27, 2021
PR-URL: nodejs#35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: nodejs#35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott
Copy link
Member Author

Trott commented Apr 27, 2021

Landed in 50bbc4e

@Trott Trott merged commit 50bbc4e into nodejs:master Apr 27, 2021
@Trott Trott deleted the debugger-Ctrl-plus branch April 27, 2021 16:05
targos pushed a commit that referenced this pull request Apr 29, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #35271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants