src: fix race condition in debug signal on exit #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
c++
| static void TryStartDebugger() { | ||
| // Call only async signal-safe functions here! Don't retry the exchange, | ||
| // it will deadlock when the thread is interrupted inside a critical section. | ||
| if (auto isolate = node_isolate.exchange(nullptr)) { |
There was a problem hiding this comment.
Hmmm, our linter doesn't complain about this?
There was a problem hiding this comment.
Why would it? It's a common C++ idiom.
|
LGTM |
|
LGTM |
|
OS X... |
|
@bnoordhuis .. ugh. |
|
Hacked together a crummy workaround. I'll refine it further but first let's see if the basic approach works: https://ci.nodejs.org/job/node-test-pull-request/619/ |
bnoordhuis
force-pushed
the
fix-debugger-race
branch
from
c25388b
to
1b0ffcc
Compare
|
Alternate take: https://ci.nodejs.org/job/node-test-pull-request/621/ |
|
Having to polyfill atomic makes me sad. Otherwise LGTM. |
| template <typename T> | ||
| struct atomic { | ||
| atomic() = default; | ||
| T exchange(T value) { return __sync_lock_test_and_set(&value_, value); } |
|
LGTM, if it works |
Before this commit, sending a SIGUSR1 at program exit could trigger a hard to reproduce race condition where `v8::Debug::DebugBreak(isolate)` got called when the isolate was in the process of being torn down. A similar race condition is in theory possible when sending signals to two threads simultaneously but I haven't been able to reproduce that myself (and I tried, oh how I tried.) This commit fixes the race condition by turning `node_isolate` into a `std::atomic` and using it as an ad hoc synchronization primitive in places where that is necessary. A bare minimum std::atomic polyfill is added for OS X because Apple wouldn't be Apple if things just worked out of the box. PR-URL: nodejs#3528 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
force-pushed
the
fix-debugger-race
branch
from
1b0ffcc
to
53e64bb
Compare
lol |
|
@bnoordhuis ... is this something that should go into LTS or not? |
bnoordhuis
added a commit
that referenced
this pull request
Oct 28, 2015
Before this commit, sending a SIGUSR1 at program exit could trigger a hard to reproduce race condition where `v8::Debug::DebugBreak(isolate)` got called when the isolate was in the process of being torn down. A similar race condition is in theory possible when sending signals to two threads simultaneously but I haven't been able to reproduce that myself (and I tried, oh how I tried.) This commit fixes the race condition by turning `node_isolate` into a `std::atomic` and using it as an ad hoc synchronization primitive in places where that is necessary. A bare minimum std::atomic polyfill is added for OS X because Apple wouldn't be Apple if things just worked out of the box. PR-URL: #3528 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in v4.x-staging in c85736e |
rvagg
pushed a commit
to rvagg/io.js
that referenced
this pull request
Oct 29, 2015
Before this commit, sending a SIGUSR1 at program exit could trigger a hard to reproduce race condition where `v8::Debug::DebugBreak(isolate)` got called when the isolate was in the process of being torn down. A similar race condition is in theory possible when sending signals to two threads simultaneously but I haven't been able to reproduce that myself (and I tried, oh how I tried.) This commit fixes the race condition by turning `node_isolate` into a `std::atomic` and using it as an ad hoc synchronization primitive in places where that is necessary. A bare minimum std::atomic polyfill is added for OS X because Apple wouldn't be Apple if things just worked out of the box. PR-URL: nodejs#3528 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
added a commit
that referenced
this pull request
Oct 29, 2015
Before this commit, sending a SIGUSR1 at program exit could trigger a hard to reproduce race condition where `v8::Debug::DebugBreak(isolate)` got called when the isolate was in the process of being torn down. A similar race condition is in theory possible when sending signals to two threads simultaneously but I haven't been able to reproduce that myself (and I tried, oh how I tried.) This commit fixes the race condition by turning `node_isolate` into a `std::atomic` and using it as an ad hoc synchronization primitive in places where that is necessary. A bare minimum std::atomic polyfill is added for OS X because Apple wouldn't be Apple if things just worked out of the box. PR-URL: #3528 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, sending a SIGUSR1 at program exit could trigger a
hard to reproduce race condition where
v8::Debug::DebugBreak(isolate)got called when the isolate was in the process of being torn down.
A similar race condition is in theory possible when sending signals
to two threads simultaneously but I haven't been able to reproduce
that myself (and I tried, oh how I tried.)
This commit fixes the race condition by turning
node_isolateintoa
std::atomicand using it as an ad hoc synchronization primitivein places where that is necessary.
R=@indutny?
CI: https://ci.nodejs.org/job/node-test-pull-request/615/