-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: use Object static properties from primordials #35380
Conversation
Review requested:
|
// Object.prototype and ObjectPrototype refer to our 'primordials' versions | ||
// and are not identical to the versions on the global object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the case anymore. primordials.Object
is the same as global.Object
and primordials.ObjectPrototype
is the same as global.Object.prototype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM! |
Commit Queue failed- Loading data for nodejs/node/pull/35380 ✔ Done loading data for nodejs/node/pull/35380 ----------------------------------- PR info ------------------------------------ Title lib: use Object static properties from primordials (#35380) Author Michaël Zasso (@targos) Branch targos:primordials-object -> nodejs:master Labels timers Commits 1 - lib: use Object static properties from primordials Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/35380 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Gerhard Stöbich Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Daijiro Wachi ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35380 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Gerhard Stöbich Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Daijiro Wachi -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Last Full PR CI on 2020-09-27T19:21:28Z: https://ci.nodejs.org/job/node-test-pull-request/33266/ - Querying data for job/node-test-pull-request/33266/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sun, 27 Sep 2020 15:42:19 GMT ✔ Approvals: 6 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/35380#pullrequestreview-497090872 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/35380#pullrequestreview-497101013 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35380#pullrequestreview-497103010 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/35380#pullrequestreview-497109414 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/35380#pullrequestreview-497162346 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35380#pullrequestreview-497191008 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu |
PR-URL: #35380 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Landed in a880653 |
This had some conflicts on v14.x, please raise a backport PR if this should land on v14.x. |
PR-URL: nodejs#35380 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #35380 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
No description provided.