doc: add an example code #35625
doc: add an example code #35625
Conversation
nodejs-github-bot
added
doc
doc/api/process.md
Outdated
| @@ -1342,6 +1342,12 @@ The `process.getgroups()` method returns an array with the supplementary group | |||
| IDs. POSIX leaves it unspecified if the effective group ID is included but | |||
| Node.js ensures it always is. | |||
|
|
|||
| ```js | |||
| if (process.getgroups) { | |||
| console.log(`Current groups: ${process.getgroups()}`); | |||
There was a problem hiding this comment.
| console.log(`Current groups: ${process.getgroups()}`); | |
| console.log(process.getgroups()); // [ 16, 21, 297 ] |
Embedding it in a string might make it less clear what the output is in this case. Raw array output might be better.
There was a problem hiding this comment.
@Trott - I understand your point and thanks for the review. I have followed your suggestion. Please have a look.
PR-URL: nodejs#35625 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
process-getgroups
branch
from
78cb167
to
f59d4e0
Compare
|
Landed in f59d4e0 @PoojaDurgad I usually don't bother contributors with this detail, but because you are opening a lot of pull requests: Usually, only the first commit needs to be formatted according to our guidelines. For subsequent commits that are small changes to your pull requests (such as in this one where you had a second commit that removed extraneous whitespace and a third commit that implemented a small suggestion from a reviewer), it helps if you use |
|
@Trott - Thanks for the suggestion. I will follow up. |
PR-URL: #35625 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#35625 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes