Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: eliminate all overhead for hidden calls #35644

Closed
wants to merge 12 commits into from
Closed

errors: eliminate all overhead for hidden calls #35644

wants to merge 12 commits into from

Commits on Dec 9, 2020

  1. errors: eliminate all overhead for hidden calls 

    Eliminate all overhead for function calls that are to be
hidden from the stack traces at the expense of
reduced performance for the error case

Fixes: nodejs#35386
    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    d03cb18 View commit details
    Browse the repository at this point in the history

  2. do not impose a limit on stack traces

    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e0b4be9 View commit details
    Browse the repository at this point in the history

  3. errors: add a benchmark for hidestackframes 

    Add @puzpuzpuz's benchmark for the new
implementation of hideStackFrames

Refs: nodejs#35386
Refs: nodejs#35644
    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    2dde837 View commit details
    Browse the repository at this point in the history

  4. errors: fix the comments for hideStackFrame 

    Fix the comments for the no-overhead hideStackFrame

Refs: nodejs#35644
    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    9e73b60 View commit details
    Browse the repository at this point in the history

  5. errors: slights improvements for hideStackFrames 

    As suggested by @puzpuzpuz and @BridgeAR
* Do not run the full loop for user-generated exceptions
* Reduce the prefix
* Add function names to the functions in errors.js
so that they keep their names in the debugger/profiler

Refs: nodejs#35644
    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    242d668 View commit details
    Browse the repository at this point in the history

  6. errors: adopt reviewers remarks 

    Adopt remarks by @puzpuzpuz and @aduh95

Refs: nodejs#35644
    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    fc43106 View commit details
    Browse the repository at this point in the history

  7. errors: remove eslint-disable after switch to primordials 

    eslint-disable line is throwing an error

Refs: nodejs#35644
    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    07d1498 View commit details
    Browse the repository at this point in the history

  8. error: replace hideStackFrames is not a constructor 

    Remove new calls for objects returned by
hideStackFrames when called with an arrow function

Refs: nodejs#35644
    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    960d269 View commit details
    Browse the repository at this point in the history

  9. errors: remove unused variable

    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    5ba86f7 View commit details
    Browse the repository at this point in the history

  10. errors: rebase and merge

    @mmomtchev
    mmomtchev committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    f7d0414 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. errors: comments and cosmetic changes

    @mmomtchev
    mmomtchev committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    67b17b7 View commit details
    Browse the repository at this point in the history

  2. Update lib/internal/errors.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @mmomtchev @aduh95
    mmomtchev and aduh95 authored Dec 15, 2020
    Configuration menu
    Copy the full SHA
    7c1d773 View commit details
    Browse the repository at this point in the history