Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update gyp-next to v0.6.2 #35690

Merged
merged 0 commits into from
Oct 17, 2020
Merged

tools: update gyp-next to v0.6.2 #35690

merged 0 commits into from
Oct 17, 2020

Conversation

targos
Copy link
Member

@targos targos commented Oct 17, 2020

No description provided.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Oct 17, 2020
@targos
Copy link
Member Author

targos commented Oct 17, 2020

Please 👍 to fast-track. We need this for #35415

@targos targos added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 17, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33687/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33688/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 17, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33689/ ✅

aduh95
aduh95 approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott
Copy link
Member

Trott commented Oct 17, 2020

Landed in 35a6946

@Trott Trott closed this Oct 17, 2020
@Trott Trott merged commit 35a6946 into nodejs:master Oct 17, 2020
@targos targos deleted the gyp-next branch October 17, 2020 11:37
@MylesBorins
Copy link
Contributor

As mentioned in #35635 (comment) should we be backporting this to v14.x LTS?

BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@targos @BethGriggs
tools: update gyp-next to v0.6.2
985efdf 
PR-URL: #35690
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Aug 18, 2021
@targos @richardlau
tools: update gyp-next to v0.6.2
dcaa7d2 
PR-URL: nodejs#35690
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @Trott @MylesBorins @aduh95