Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] src: create helper for reading Uint32BE #35701

Closed
wants to merge 1 commit into from
Closed

[v14.x backport] src: create helper for reading Uint32BE #35701

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Oct 18, 2020 •
edited
Loading

Refs: #34944

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v14.x labels Oct 18, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34693/

BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@juanarbol @BethGriggs
src: create helper for reading Uint32BE
7057d34 
Fixes: #34827

Backport-PR-URL: #35701
PR-URL: #34944
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs
Copy link
Member

Landed in 7057d34

@BethGriggs BethGriggs closed this Dec 9, 2020
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@juanarbol @BethGriggs
src: create helper for reading Uint32BE
28612ba 
Fixes: #34827

Backport-PR-URL: #35701
PR-URL: #34944
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@juanarbol @BethGriggs
src: create helper for reading Uint32BE
f230039 
Fixes: #34827

Backport-PR-URL: #35701
PR-URL: #34944
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@juanarbol juanarbol deleted the backport-34944-to-14.x branch January 19, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanarbol @nodejs-github-bot @BethGriggs