test: fix heap-profiler link error LNK1194 on win #3572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but can you update the commit log to include the error message? |
Fix the following error message in windows using VS 2013 LINK : fatal error LNK1194: cannot delay-load 'node.exe' due to import of data symbol '"__declspec(dllimport) const v8::OutputStream::`vftable'" (__imp_??_7OutputStream@v8@@6b@)'; link without /DELAYLOAD:node.exe
mscdex
added
windows
john-yan
force-pushed
the
heap-profiler-fix
branch
from
1e53baf
to
3bcbc19
Compare
|
@bnoordhuis commit log is updated. Please check if I am doing the right thing. Thanks. |
|
can someone help add the lts-watch-v4.x tag? thanks. |
bnoordhuis
pushed a commit
that referenced
this pull request
Oct 28, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: #3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Thanks, tagged and landed in 9f96705. |
rvagg
pushed a commit
to rvagg/io.js
that referenced
this pull request
Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: nodejs#3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
john-yan
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: nodejs/node#3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
pushed a commit
that referenced
this pull request
Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: #3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
pushed a commit
that referenced
this pull request
Oct 29, 2015
Fix the following error message in windows using VS 2013:
LINK : fatal error LNK1194: cannot delay-load 'node.exe'
due to import of data symbol '"__declspec(dllimport)
const v8::OutputStream::`vftable'"
(__imp_??_7OutputStream@v8@@6b@)'; link without
/DELAYLOAD:node.exe
PR-URL: #3572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in v4.x-staging in a8c24ce |
|
I have the same issue ,but without solved by using adding 'win_delay_load_hook': 'false', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following error on windows with VS 2013: