lib: fix stream as context is redundant #35728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Codecov Report
@@ Coverage Diff @@
## master #35728 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 222 223 +1
Lines 73682 73685 +3
=======================================
+ Hits 71033 71036 +3
Misses 2649 2649
Continue to review full report at Codecov.
|
lpinca
approved these changes
Oct 21, 2020
lib/internal/streams/from.js
Outdated
| // being called before last iteration completion. | ||
| let reading = false; | ||
|
|
||
| // needToClose boolean if iterator needs to be explicitly closed | ||
| // Flag for iterator when needs to be explicitly closed |
There was a problem hiding this comment.
Suggested change
| // Flag for iterator when needs to be explicitly closed | |
| // Flag for iterator when needs to be explicitly closed. |
|
The subsystem in commit title should be |
yashLadha
force-pushed
the
improve_stream_from_doc
branch
from
043cd17
to
daa264f
Compare
|
Updated @lpinca |
gireeshpunathil
approved these changes
Oct 21, 2020
gireeshpunathil
added
request-ci
github-actions
bot
removed
the
request-ci
ronag
approved these changes
Oct 21, 2020
Trott
reviewed
Oct 21, 2020
lib/internal/streams/from.js
Outdated
| // being called before last iteration completion. | ||
| let reading = false; | ||
|
|
||
| // needToClose boolean if iterator needs to be explicitly closed | ||
| // Flag for iterator when needs to be explicitly closed. |
There was a problem hiding this comment.
Suggested change
| // Flag for iterator when needs to be explicitly closed. | |
| // Flag for when iterator needs to be explicitly closed. |
There was a problem hiding this comment.
Made suggested changes 👍
|
The commit message ( |
antsmartian
approved these changes
Oct 21, 2020
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams.
yashLadha
force-pushed
the
improve_stream_from_doc
branch
from
daa264f
to
2aa775a
Compare
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 25, 2020
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: #35728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
landed in 364ac78 |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: #35728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: #35728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: #35728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: #35728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the variable name in the comment and justifying the type seems
redundant to me and instead it should defined the entity which it is
acting, like in our case it is acting as a flag to control the flow in
streams.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes