Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: use more primordials #35734

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 21, 2020

Backport requested because optional chaining is not available on Node.js 12. No need for optional chaining after all 😅

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Oct 21, 2020
@aduh95 aduh95 added backport-requested-v12.x request-ci Add this label to start a Jenkins CI on a PR. labels Oct 21, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
@nodejs-github-bot

This comment has been minimized.

@aduh95
Copy link
Contributor Author

aduh95 commented Oct 21, 2020

Why am I getting TypeError: StringPrototypeReplaceAll is not a function? 🤔

@targos
Copy link
Member

targos commented Oct 21, 2020

My guess is that the method is not available to primordials because it can be disabled in V8 with node --no-harmony-string-replaceall.

@codecov-io

This comment has been minimized.

@aduh95
Copy link
Contributor Author

aduh95 commented Oct 21, 2020

My guess is that the method is not available to primordials because it can be disabled in V8 with node --no-harmony-string-replaceall.

Interesting. Well I guess we'll have to refrain from using it in node core for the time being then…

@nodejs-github-bot

This comment has been minimized.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed backport-requested-v12.x labels Oct 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the review wanted PRs that need reviews. label Oct 28, 2020
@aduh95 aduh95 requested a review from targos October 28, 2020 15:34
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 29, 2020

@nodejs/console Can you review this please?

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a rebase

@aduh95 aduh95 force-pushed the console-refactor-primordials branch from 446aa98 to f2c9f81 Compare October 31, 2020 18:57
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2020
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 mentioned this pull request Nov 1, 2020
2 tasks
PR-URL: nodejs#35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the console-refactor-primordials branch from f2c9f81 to 1f6ca18 Compare November 5, 2020 22:12
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 5, 2020

Landed in 1f6ca18

@aduh95 aduh95 merged commit 1f6ca18 into nodejs:master Nov 5, 2020
@aduh95 aduh95 deleted the console-refactor-primordials branch November 5, 2020 22:13
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35734
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants