Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use kbd element in readline doc prose #35737

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 21, 2020

The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Oct 21, 2020
@Trott
Copy link
Member Author

Trott commented Oct 21, 2020

Before:

image

After:

image

@codecov-io
Copy link

Codecov Report

Merging #35737 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35737      +/-   ##
==========================================
- Coverage   96.40%   96.40%   -0.01%     
==========================================
  Files         223      223              
  Lines       73685    73685              
==========================================
- Hits        71038    71035       -3     
- Misses       2647     2650       +3     
Impacted Files Coverage Δ
lib/_http_server.js 98.34% <0.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c4239b...8234f2d. Read the comment docs.

The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.

PR-URL: nodejs#35737
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@Trott Trott merged commit dd43715 into nodejs:master Oct 26, 2020
@Trott
Copy link
Member Author

Trott commented Oct 26, 2020

Landed in dd43715

@Trott Trott deleted the one-moar-kbd branch October 26, 2020 10:34
targos pushed a commit that referenced this pull request Nov 3, 2020
The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.

PR-URL: #35737
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.

PR-URL: #35737
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.

PR-URL: #35737
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
The kbd element has already been added in the keybindings table, but we
missed it in one line in the prose.

PR-URL: #35737
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants