Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: move events to the JSStreamSocket #35772

Merged
merged 2 commits into from
Nov 8, 2020

Commits on Nov 8, 2020

  1. http2: move events to the JSStreamSocket

    When using a JSStreamSocket, the
    HTTP2Session constructor will replace
    the socket object
    http2 events should be attached to the
    JSStreamSocket object because the http2
    session handle lives there
    
    Fixes: nodejs#35695
    
    PR-URL: nodejs#35772
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    mmomtchev authored and Trott committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    6abb7e5 View commit details
    Browse the repository at this point in the history
  2. http2: centralise socket event binding in Http2Session

    Move the socket event binding to the
    HTTP2Session constructor so that an error
    event could be delivered should the
    constructor fail
    
    Ref: nodejs#35772
    
    PR-URL: nodejs#35772
    Fixes: nodejs#35695
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    mmomtchev authored and Trott committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    adae822 View commit details
    Browse the repository at this point in the history