Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add upstream test cases to urlsearchparams #35792

Merged
merged 1 commit into from
Oct 27, 2020
Merged

test: add upstream test cases to urlsearchparams #35792

merged 1 commit into from
Oct 27, 2020

Conversation

watilde
Copy link
Member

@watilde watilde commented Oct 25, 2020

Refs: web-platform-tests/wpt#26126

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020
@codecov-io

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Trott
Trott approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@watilde watilde added dont-land-on-v14.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33884/

@watilde @Trott
test: add upstream test cases to urlsearchparam
f9c9c21 
Refs: web-platform-tests/wpt#26126

PR-URL: nodejs#35792
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 27, 2020

Landed in f9c9c21

@Trott Trott merged commit f9c9c21 into nodejs:master Oct 27, 2020
@watilde watilde deleted the wpt-url branch October 27, 2020 14:01
targos pushed a commit that referenced this pull request Nov 3, 2020
@watilde @targos
test: add upstream test cases to urlsearchparam
76991c0 
Refs: web-platform-tests/wpt#26126

PR-URL: #35792
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@watilde @nodejs-github-bot @codecov-io @Trott @jasnell @lpinca