events: add a few tests #35806

benjamingr · 2020-10-26T09:13:53Z

Added a few EventTarget tests I've found by playing with the code and "porting" bits of the spec I've read.

Note that at the moment Chrome has different prototype keys for Event though I could not figure out if that bit is actually required by the spec.

Object.keys(Object.getPrototypeOf(new Event('foo'))); // different between chrome and Node

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

targos · 2020-10-26T09:38:21Z

Port a few tests from what (commit message)?

benjamingr · 2020-10-26T09:54:26Z

I initially wanted to port tests from chromium but couldn't find relevant ones - so I just went over the spec looking for bits we don't cover and added tests for them.

codecov-io · 2020-10-26T10:22:13Z

Codecov Report

Merging #35806 into master will decrease coverage by 8.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #35806      +/-   ##
==========================================
- Coverage   96.87%   87.89%   -8.98%     
==========================================
  Files         212      477     +265     
  Lines       69486   113171   +43685     
  Branches        0    25427   +25427     
==========================================
+ Hits        67315    99475   +32160     
- Misses       2171     7994    +5823     
- Partials        0     5702    +5702

Impacted Files	Coverage Δ
lib/internal/crypto/scrypt.js	`28.33% <0.00%> (-71.67%)`	⬇️
lib/internal/idna.js	`55.55% <0.00%> (-11.12%)`	⬇️
lib/internal/blocklist.js	`88.70% <0.00%> (-10.49%)`	⬇️
lib/internal/crypto/diffiehellman.js	`89.36% <0.00%> (-9.61%)`	⬇️
lib/internal/modules/esm/get_source.js	`83.33% <0.00%> (-7.15%)`	⬇️
lib/internal/modules/esm/get_format.js	`86.11% <0.00%> (-6.95%)`	⬇️
lib/internal/streams/legacy.js	`93.85% <0.00%> (-6.15%)`	⬇️
lib/internal/crypto/keys.js	`93.32% <0.00%> (-5.89%)`	⬇️
lib/internal/crypto/util.js	`94.32% <0.00%> (-5.68%)`	⬇️
lib/internal/histogram.js	`79.78% <0.00%> (-5.32%)`	⬇️
... and 405 more

test/parallel/test-eventtarget.js

lib/internal/event_target.js

benjamingr · 2020-11-03T14:31:17Z

Rebased

nodejs-github-bot · 2020-11-03T14:36:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34039/

github-actions · 2020-11-03T16:05:47Z

Commit Queue failed

- Loading data for nodejs/node/pull/35806
✔  Done loading data for nodejs/node/pull/35806
----------------------------------- PR info ------------------------------------
Title      events: add a few tests (#35806)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     benjamingr:event-target-tests -> nodejs:master
Labels     author ready, events, test
Commits    1
 - events: add a few tests
Committers 1
 - Benjamin Gruenbaum 
PR-URL: https://github.com/nodejs/node/pull/35806
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35806
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - events: add a few tests
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2020-11-03T14:36:19Z: https://ci.nodejs.org/job/node-test-pull-request/34039/
- Querying data for job/node-test-pull-request/34039/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Mon, 26 Oct 2020 09:13:53 GMT
   ✔  Approvals: 2
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35806#pullrequestreview-516666200
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35806#pullrequestreview-516905787
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/343910509

benjamingr · 2020-11-03T16:08:33Z

@aduh95 can you LGTM after the rebase so I can land with the commit queue? (assuming you think the changes are LGTM)

aduh95

RSLGTM

github-actions · 2020-11-03T17:16:59Z

Landed in 1bc1f84...ee749ba

PR-URL: #35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #35806 Backport-PR-URL: #38386 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

benjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label Oct 26, 2020

benjamingr requested a review from jasnell October 26, 2020 09:13

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 26, 2020

benjamingr changed the title ~~events: port a few tests from~~ events: add a few tests Oct 26, 2020

benjamingr force-pushed the event-target-tests branch from b7efa9f to 702b621 Compare October 26, 2020 09:54

Trott approved these changes Oct 26, 2020

View reviewed changes

jasnell reviewed Oct 26, 2020

View reviewed changes

test/parallel/test-eventtarget.js Show resolved Hide resolved

jasnell approved these changes Oct 26, 2020

View reviewed changes

benjamingr mentioned this pull request Oct 26, 2020

events: make abort_controller event trusted #35811

Closed

3 tasks

benjamingr force-pushed the event-target-tests branch from 702b621 to c363016 Compare October 26, 2020 16:28

benjamingr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2020

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

This comment has been minimized.

Sign in to view

ExE-Boss reviewed Oct 28, 2020

View reviewed changes

lib/internal/event_target.js Outdated Show resolved Hide resolved

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

benjamingr force-pushed the event-target-tests branch from 54624c7 to 3ad306a Compare October 28, 2020 18:23

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

This comment has been minimized.

Sign in to view

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

This comment has been minimized.

Sign in to view

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2020

This comment has been minimized.

Sign in to view

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2020

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 3, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2020

benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 3, 2020

github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 3, 2020

aduh95 approved these changes Nov 3, 2020

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 3, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 3, 2020

github-actions bot closed this Nov 3, 2020

nodejs-github-bot pushed a commit that referenced this pull request Nov 3, 2020

events: add a few tests

ee749ba

PR-URL: #35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Nov 4, 2020

events: add a few tests

1cdfaa8

PR-URL: #35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Nov 4, 2020

v15.1.0 release proposal #35948

Merged

ExE-Boss mentioned this pull request Feb 5, 2021

lib: fix WebIDL object and dictionary type conversion #37047

Merged

targos added the backport-open-v14.x label Apr 24, 2021

targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021

events: add a few tests

e6443f2

PR-URL: nodejs#35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Apr 24, 2021

[v14.x] Backport AbortController and friends #38386

Closed

targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021

events: add a few tests

6eff327

PR-URL: nodejs#35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021

events: add a few tests

01d2b67

PR-URL: nodejs#35806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Apr 30, 2021

events: add a few tests

6558ffa

PR-URL: #35806 Backport-PR-URL: #38386 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v14.x labels Apr 30, 2021

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

events: add a few tests #35806

events: add a few tests #35806

benjamingr commented Oct 26, 2020

targos commented Oct 26, 2020 •

edited

Loading

benjamingr commented Oct 26, 2020

codecov-io commented Oct 26, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

benjamingr commented Nov 3, 2020

nodejs-github-bot commented Nov 3, 2020

github-actions bot commented Nov 3, 2020

benjamingr commented Nov 3, 2020 •

edited

Loading

aduh95 left a comment

github-actions bot commented Nov 3, 2020

events: add a few tests #35806

events: add a few tests #35806

Conversation

benjamingr commented Oct 26, 2020

Checklist

targos commented Oct 26, 2020 • edited Loading

benjamingr commented Oct 26, 2020

codecov-io commented Oct 26, 2020

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

benjamingr commented Nov 3, 2020

nodejs-github-bot commented Nov 3, 2020

github-actions bot commented Nov 3, 2020

benjamingr commented Nov 3, 2020 • edited Loading

aduh95 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 3, 2020

targos commented Oct 26, 2020 •

edited

Loading

benjamingr commented Nov 3, 2020 •

edited

Loading