Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make small improvements to REPL doc #35808

Merged
merged 1 commit into from
Oct 28, 2020
Merged

doc: make small improvements to REPL doc #35808

merged 1 commit into from
Oct 28, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 26, 2020

  • button -> key
  • apply missing kbd element
  • revise "Recoverable errors" text for brevity and clarity
Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Oct 26, 2020
@Trott
doc: make small improvements to REPL doc
937b70d 
* button -> key
* apply missing kbd element
* revise "Recoverable errors" text for brevity and clarity

PR-URL: nodejs#35808
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 28, 2020

Landed in 937b70d

@Trott Trott merged commit 937b70d into nodejs:master Oct 28, 2020
@Trott Trott deleted the repl-button branch October 28, 2020 13:30
targos pushed a commit that referenced this pull request Nov 3, 2020
@Trott @targos
doc: make small improvements to REPL doc
8074f69 
* button -> key
* apply missing kbd element
* revise "Recoverable errors" text for brevity and clarity

PR-URL: #35808
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@Trott @BethGriggs
doc: make small improvements to REPL doc
43549d7 
* button -> key
* apply missing kbd element
* revise "Recoverable errors" text for brevity and clarity

PR-URL: #35808
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@Trott @BethGriggs
doc: make small improvements to REPL doc
5e426b5 
* button -> key
* apply missing kbd element
* revise "Recoverable errors" text for brevity and clarity

PR-URL: #35808
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@Trott @BethGriggs
doc: make small improvements to REPL doc
2984974 
* button -> key
* apply missing kbd element
* revise "Recoverable errors" text for brevity and clarity

PR-URL: #35808
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @lpinca @watilde @aduh95 @nodejs-github-bot